Add tests for memory leak - #781
Conversation
24019d4 to
82f2a98
Compare
|
let's not use the sample for leak tests, as the pipeline won't automate it. Alexandre Zollinger Chohfi (@azchohfi) recently implemented mstest support for WinUI. It should land on nuget.org any day: Ideally, we can take the ObjectLifetimeTests, add a few more, and run them as proper unit tests. |
I agree with that, but at the same time I think until we have those, we need a set of scenarios that we can quickly run through to demonstrate as we do leak fixes that we haven't regressed anything and I feel like these samples help with that. What do you think? |
I'm okay with an IOU - let's drop a comment in the samples to that effect, and open an issue to back this all out when we add unit tests. |
ee8f4c7 to
1f15e44
Compare
|
Opened #784 per discussion here |
|
|
||
| <StackPanel> | ||
| <Button Content="Navigate to SecondPage" Click="Button_Click" /> | ||
| <TextBlock x:Name="Status">Statu</TextBlock> |
There was a problem hiding this comment.
This was my typo, should be Status.
There was a problem hiding this comment.
Will get this in final commit too
Scott Jones (Scottj1s)
left a comment
Scott Jones (Scottj1s)
left a comment
There was a problem hiding this comment.
given Alex's note about winui test support on nuget.org now, can we avoid this churn and just move up directly?
Scott Jones (Scottj1s)
left a comment
Scott Jones (Scottj1s)
left a comment
There was a problem hiding this comment.
consider winuitest support in latest MSTest.TestFramework
4 participants
This PR consolidates the leak repro samples/tests from Manodasan Wignarajah (@manodasanW) 's topic branch into the existing WinUI tests/samples we have. This cuts down on the size of the solution primarily, and also acts as the first step in merging leak fixes.